Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes symlink creation under Windows #742

Merged
merged 3 commits into from
Jun 10, 2020
Merged

Removes symlink creation under Windows #742

merged 3 commits into from
Jun 10, 2020

Conversation

OgreTransporter
Copy link
Contributor

Creating symbolic links during installation does not work on Windows. Example:

EXEC : CMake error : failed to create symbolic link 'Imath.dll': operation not permitted

It is useless anyway, because when distributing the DLLs to other systems the links do not work anymore. The links have to be recreated on each system. This must then be integrated into the installation program.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 26, 2020

CLA Check
The committers are authorized under a signed CLA.

@OgreTransporter
Copy link
Contributor Author

See issue #741 and #739

Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the patch!

@meshula
Copy link
Contributor

meshula commented May 27, 2020

The DCO bot requires a sign off - if you hit the Details button it tells you how to amend the commit.

@cary-ilm cary-ilm merged commit 7f9e1b4 into AcademySoftwareFoundation:master Jun 10, 2020
@cary-ilm cary-ilm added this to the v2.5.2 milestone Jun 11, 2020
@OgreTransporter OgreTransporter deleted the fix-win32-symlink branch June 12, 2020 14:31
@meshula meshula added Build A problem with building or installing the library. Windows labels Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build A problem with building or installing the library. v2.5.2 Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants