Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the use of Pthreads with WIN32/64 builds under MinGW #673

Closed
wants to merge 5 commits into from
Closed

Allow the use of Pthreads with WIN32/64 builds under MinGW #673

wants to merge 5 commits into from

Conversation

meshula
Copy link
Contributor

@meshula meshula commented Feb 26, 2020

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 26, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@meshula meshula mentioned this pull request Feb 26, 2020
Closed
@cary-ilm cary-ilm added the Needs Discussion To be discussed in the technical steering committee label Feb 27, 2020
@lgritz
Copy link
Contributor

lgritz commented Feb 27, 2020

Can we give this a better title?

@cary-ilm cary-ilm changed the title Issue 591 Clean up #if defined logic for WIN64 and PTHREAD Feb 27, 2020
@meshula meshula changed the title Clean up #if defined logic for WIN64 and PTHREAD Allow the use of Pthreads with WIN32/64 builds under MinGW Feb 28, 2020
@meshula
Copy link
Contributor Author

meshula commented Feb 28, 2020

@lgritz embettered.

@cary-ilm
Copy link
Member

cary-ilm commented Apr 2, 2020

This looks good to me, @meshula can you get your CLA squared away?

@cary-ilm
Copy link
Member

@meshula, We'd like to get this into the 2.5 release. Can you resolve the CLA issue?

cary-ilm
cary-ilm approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cary-ilm added a commit to cary-ilm/openexr that referenced this pull request May 1, 2020
@cary-ilm
A clean version of AcademySoftwareFoundation#673: Allow the use of Pt…
4da7a2e 
…hreads with WIN32/64 builds under MinGW

Signed-off-by: Cary Phillips <cary@ilm.com>
@cary-ilm
Copy link
Member

cary-ilm commented May 1, 2020

@meshula, something got mangled in the merge here, but rather than try to untangled it, I diff'ed your changes into a fresh PR, can you try out #707 and confirm it behaves properly, the same as #673? If so, give it a review and I'll merge it into 2.5.0, then close #673 out.

cary-ilm added a commit that referenced this pull request May 3, 2020
@cary-ilm
A clean version of #673: Allow the use of Pthreads with WIN32/64 buil…
3ab677b 
…ds under MinGW

Signed-off-by: Cary Phillips <cary@ilm.com>
@cary-ilm
Copy link
Member

cary-ilm commented May 3, 2020

This has been covered by #707.

@cary-ilm cary-ilm closed this May 3, 2020
smartin-13 pushed a commit to smartin-13/openexr that referenced this pull request Jul 23, 2020
@cary-ilm @smartin-13
A clean version of AcademySoftwareFoundation#673: Allow the use of Pt…
eb614fa 
…hreads with WIN32/64 builds under MinGW

Signed-off-by: Cary Phillips <cary@ilm.com>
Signed-off-by: smartin-13 <61707536+smartin-13@users.noreply.github.com>
@meshula meshula deleted the issue-591 branch March 30, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cary-ilm cary-ilm cary-ilm approved these changes

Assignees
No one assigned
Labels
Needs Discussion To be discussed in the technical steering committee
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meshula @lgritz @cary-ilm