OpenEXR/IlmImf/ImfHuf.cpp: Fix OS dependent exr binary data for piz. #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: piz compressed binary data was OS dependent e.g. different betw linux and osx. For example if one did a md5 checksum on the compressed data of an exr with identical image pixel/channel data it would return different checksums on linux and osx for the Piz compressor. This was due to the fact that the encoding huffman table stored, while having the same entries on linux and osx were sorted differently due to the differing behavior of STL heap sort for encode table entries that were equivalent. Fix was to simply update the heap compare operator to also handled this equality case. Updated: OpenEXR/IlmImfTest/testHuf.cpp to test for identical platform/os piz compressed exr file data blocks. Signed-off-by: Arkell Rasiah <arasiah@pixsystem.com>
|
|
cary-ilm
approved these changes
Jan 16, 2020
cary-ilm
added
the
Needs Discussion
meshula
requested changes
Jan 16, 2020
meshula
approved these changes
Jan 17, 2020
…tic data sets. Updated to run compressVerify() on the fill4() and fill5() data sets which are deterministic across platforms. Added a comment to explain how these DEK hash are determined aprior for code defines. Signed-off-by: Arkell Rasiah <arasiah@pixsystem.com>
arkellr
force-pushed
the
bugfix/arkellr-imfhuf-table-order
branch
from
9832b4f
to
adffcc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: piz compressed binary data was OS dependent e.g. different betw linux
and osx. For example if one did a md5 checksum on the compressed data of an exr with identical image pixel/channel data it would return different checksums on linux and osx for the Piz compressor.
This was due to the fact that the encoding huffman table stored, while having the same entries on linux and osx were sorted differently due to the differing behavior of STL heap sort for encode table entries that were equivalent.
Fix was to simply update the heap compare operator to also handled this equality case.
Updated: OpenEXR/IlmImfTest/testHuf.cpp to test for identical platform/os piz compressed exr file data blocks.
Signed-off-by: Arkell Rasiah arasiah@pixsystem.com