Fixes #593, others - issues with pyilmbase install #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstall The PyIlmBase install logic was incomplete in cmake. This fixes this: - computes a relative path from the python paths that can then be used with CMAKE_INSTALL_PREFIX to install python modules to an appropriate location (can be manually configured as well, install docs updated) - Fixes AcademySoftwareFoundation#604, pyilmbaseconfig was also not being installed properly Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Seems like under windows, the introduced relative path search can cause an infinite loop if it doesn't match. Test for that, may need adjustment. Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
The get_filename_component gets stuck under windows when finding the parent directory for a drive letter. This basically reverts to using the full path, which is more likely to be ok under windows Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
…paring This fixes an issue under windows where the root is not properly strequal Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
meshula
reviewed
Nov 6, 2019
| @@ -55,48 +55,47 @@ endif() | |||
| # for our other dependency - boost. | |||
| # Boost Python has some .. annoyances in that the python module | |||
| # has version names attached to it | |||
| function(PYILMBASE_EXTRACT_REL_SITEARCH varname pyver pyexe pysitearch) | |||
There was a problem hiding this comment.
I bet it's going to be far less work to port Imath to pybind11, than to deal with endless boost::python/cmake curveballs!
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
…messages Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
we always build shared libraries now, so even if the default is to build static, the python bindings are forced to build shared, which means they need to set the defines to export the symbols appropriately, add extra variable set Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
…in32 Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PyIlmBase install logic was incomplete in cmake. This fixes this:
with CMAKE_INSTALL_PREFIX to install python modules to an appropriate
location (can be manually configured as well, install docs updated)
Signed-off-by: Kimball Thurston kdt3rd@gmail.com