Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 2.4 release branch #599

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Conversation

lgritz
Copy link
Contributor

@lgritz lgritz commented Oct 24, 2019

  • Bump release version to 2.4.1

  • Add RB-2.4 to the list of branches that will get Azure CI runs.

Signed-off-by: Larry Gritz lg@imageworks.com

* Bump release version to 2.4.1

* Add RB-2.4 to the list of branches that will get Azure CI runs.

Signed-off-by: Larry Gritz <lg@imageworks.com>
@lgritz lgritz requested review from kdt3rd and xlietz October 24, 2019 21:02
@lgritz
Copy link
Contributor Author

lgritz commented Oct 25, 2019

I don't think these test failures are because of my change. Can somebody diagnose? I'm not sure I understand what's going on.

@xlietz
Copy link
Contributor

xlietz commented Oct 25, 2019

I agree doesn't look an issue in my Azure setup not your change. I'll look into it this weekend - need to get all python-related tests running correctly on all platforms, The failing tests on the Mac build here are both python2 tests but refer to boost-python3 in the error which is suspicious.

The SonarCloud scan should not have run at all. It's getting the same authorization error we saw when running on PRs recently. I'll try to figure out why it ran.

Otherwise this LGTM and I dont think you need to wait on clean builds to merge unless you prefer to.

@lgritz
Copy link
Contributor Author

lgritz commented Oct 25, 2019

No, thanks @xlietz, I think I will merge since I don't see any reason why the failures would be from my simply bumping the version number.

@lgritz lgritz merged commit 486ff10 into AcademySoftwareFoundation:RB-2.4 Oct 25, 2019
@cary-ilm cary-ilm added this to the v2.5.0 milestone Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants