Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use previously-built native generators when building with CMake. #597

Conversation

Lord-Kamina
Copy link
Contributor

Just split this off from #591 as requested.

@cary-ilm cary-ilm added the Needs Discussion To be discussed in the technical steering committee label Oct 24, 2019
@cary-ilm cary-ilm self-assigned this Oct 24, 2019
@cary-ilm
Copy link
Member

The preferred solution here is to commit the auto-generated eLut.h, toFloat.h, b33ExpLogTable.h to the repo as regular source files and disable the auto-generation step altogether, but also have a "generate-headers" make target to runs the generation, and then have the unit tests generate the tables and compare the results. That way, the complexity of the generation is relegated to the tests, and eliminated from the build itself. I agreed to do this but haven't gotten to it yet.

@cary-ilm cary-ilm removed the Needs Discussion To be discussed in the technical steering committee label Oct 31, 2019
@cary-ilm
Copy link
Member

Addressed by #606, which removes the auto-generation of the headers entirely. They're regular header files in the repo now.

@cary-ilm cary-ilm closed this Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants