Fix for #263: prevent overflow in multipart chunk offset reconstruction #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chunk offset table reconstruction
meshula
reviewed
Jul 10, 2019
| if(y_coordinate < header.dataWindow().min.y || y_coordinate > header.dataWindow().max.y) | ||
| { | ||
| // bail to exception catcher: y out of range. Test now to prevent overflow in following arithmetic | ||
| throw int(); |
There was a problem hiding this comment.
throw int() occurs four times in this file, and nowhere else. I suspect it's legacy. Probably
throw IEX_NAMESPACE::IoExc("y out of range");
and similar should replace all the throw int() in this file. Should we hit all four in this commit?
There was a problem hiding this comment.
I'll do that. I think I originally wrote those intending to refactor them out.
I think they can be replaced with break but throwing an exception with a message as you suggest will make it easier to debug
cary-ilm
reviewed
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change. The original test is probably redundant now, but I'm not completely sure that there isn't an edge case