Fix #350 - memory leak on exit #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes CVE-2018-18443, the last thread pool provider set into the pool was not being correctly cleaned up at shutdown of the thread pool. Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Closed
|
Looks good to me. |
cary-ilm
approved these changes
Jun 27, 2019
xerus
pushed a commit
to xerus/opencv
that referenced
this pull request
Oct 27, 2019
Direct leak of 8 byte(s) in 1 object(s) allocated from:
#0 0x5d9c7f in operator new(unsigned long) (/home/pgrunt/src/image_flat/build_asan/iface/unit_tests/iface_unittest+0x5d9c7f)
opencv#1 0x7fa5e5fbce7a in IlmThread_opencv::ThreadPool::ThreadPool(unsigned int) /home/pgrunt/src/image_flat/ext_libs/opencv/3rdparty/openexr/IlmThread/IlmThreadPool.cpp:758:29
opencv#2 0x7fa5e5fbce7a in IlmThread_opencv::ThreadPool::globalThreadPool() /home/pgrunt/src/image_flat/ext_libs/opencv/3rdparty/openexr/IlmThread/IlmThreadPool.cpp:838
Taken from AcademySoftwareFoundation/openexr#412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes CVE-2018-18443, the last thread pool provider set into the
pool was not being correctly cleaned up at shutdown of the thread pool.
Signed-off-by: Kimball Thurston kdt3rd@gmail.com