Bazel Build: Bump libdeflate to 1.21 #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vertexwahn <julian.amann@tum.de>
cary-ilm
approved these changes
Aug 11, 2024
cary-ilm
merged commit de81234
into
AcademySoftwareFoundation:main
31 of 32 checks passed
|
@Vertexwahn @cary-ilm Per Matt's note here https://academysoftwarefdn.slack.com/archives/CMLRW4N73/p1728604403705269?thread_ts=1728593076.273849&cid=CMLRW4N73 Is there a motivator to move to 1.21? I'm all for staying current, I'm just wondering what prompted it and if there's something we should pay attention to. cmake loads 1.18, and this PR bumped bazel to 1.21. Any reason not to bump the cmake version as well? It's not awesome they've diverged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel Build: Bump libdeflate to 1.21