Silence warning C4201: nonstandard extension used: nameless struct/union. #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. Signed-off-by: Dirk Lemstra <dirk@lemstra.org>
dlemstra
force-pushed
the
silence-warning
branch
from
6ef66fe
to
513da35
Compare
|
I had originally added these in anticipation of making simple types for imath, which allows subscript access, but that plan I think has changed. I am ok with making this change. Do note that the Core library, when being compiled, does require C11 as it uses atomics. (although users of the library do not have that requirement) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am checking if we could switch to the "new" OpenEXRCore api in the @ImageMagick project and I we are getting a build warning when including
openexr.hin our Visual Studio project:An anonymous struct, is not part of the standard ANSI C (C89/C90) or ISO C90. It was introduced in C11 as an optional feature and might not be supported by all compilers, especially in strict ANSI C modes. This PR simplifies the structs to silence this warning.