Build website on windows/macOS, and remote unnecessary installs #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readthedocs builds the website on ubuntu-20.04, so technically that's the only system that requires the website to build properly, but developers contributing to the website may work on Windows or macOS, so this confirms that it builds properly there, too. Now that the test image files are no longer generated at build time, no need to install imagemagic and openexr or run the test_image.py script. Signed-off-by: Cary Phillips <cary@ilm.com>
|
Thanks Cary, I think this solved #1580 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readthedocs builds the website on ubuntu-20.04, so technically that's the only system that requires the website to build properly, but developers contributing to the website may work on Windows or macOS, so this confirms that it builds properly there, too.
Now that the test image files are no longer generated at build time, no need to install imagemagic and openexr or run the test_image.py script.
Website preview: https://openexr--1701.org.readthedocs.build/en/1701/