Replace auto-generation of website test image with explicit sidecar jpg files #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatically generating .jpg images for display under "Test Images" as a step in building the website seemed like a good idea a the time, but is too hard to maintain. I couldn't get the process to work across Linux, macOS, and Windows, which means no Windows/macOS-based developers can contribute to the website. The https://github.com/AcademySoftwareFoundation/openexr-images repo now has a permenant sidecar .jpg file associated with each .exr which serves as a proxy for display on the website. The `website/scripts/test_images.py` is still in place but is now to be run manually to generate the website `.rst` and the associated `.rst` files describing each image. Anyone providing additional test images to the`openexr-image` repo should contribute an associated `.jpg` for display. To contribute additional images, first add the images to the image repo, then run the `website/scripts/test_image.py`, and commit the new/modified `.rst` files(s). Signed-off-by: Cary Phillips <cary@ilm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically generating .jpg images for display under "Test Images" as a step in building the website seemed like a good idea a the time, but is too hard to maintain. I couldn't get the process to work across Linux, macOS, and Windows, which means no Windows/macOS-based developers can contribute to the website.
The https://github.com/AcademySoftwareFoundation/openexr-images repo now has a permenant sidecar .jpg file associated with each .exr which serves as a proxy for display on the website.
The
website/scripts/test_images.pyis still in place but is now to be run manually to generate the website.rstand the associated.rstfiles describing each image. Anyone providing additional test images to theopenexr-imagerepo should contribute an associated.jpgfor display.To contribute additional images, first add the images to the image repo, then run the
website/scripts/test_image.py, and commit the new/modified.rstfiles(s).Website preview: https://openexr--1667.org.readthedocs.build/en/1667/