#1545 Fix formatting of sample exr file in OpenEXRFileLayout.rst - 3rd attempt #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with bytes of the sample file in one column. The value in the second column and the third column being the description of the bytes and value. Signed-off-by: An Nguyen <annguyen@ilm.com>
* Gave the table a title and reduce the width to 50% Signed-off-by: An Nguyen <annguyen@ilm.com>
…ndow value Signed-off-by: An Nguyen <annguyen@ilm.com>
Signed-off-by: An Nguyen <annguyen@ilm.com>
…learer. Signed-off-by: An Nguyen <annguyen@ilm.com>
Signed-off-by: An Nguyen <annguyen@ilm.com>
Signed-off-by: An Nguyen <annguyen@ilm.com>
…the table to describe the table Signed-off-by: An Nguyen <annguyen@ilm.com>
…arget destination naming scheme to avoid confusion where the files go when built Signed-off-by: An Nguyen <annguyen@ilm.com>
|
Thanks for getting this sorted out! Do you have a link to the output html on your readthedocs? There were a few anomalies in the previous iteration I wanted to comment on, but it looks like it's gone away. |
cary-ilm
requested changes
Oct 27, 2023
Signed-off-by: An Nguyen <annguyen@ilm.com>
|
https://openexr-annguyen.readthedocs.io/en/latest/OpenEXRFileLayout.html#sample-file |
|
This looks better, thanks! I've been busy on other things and I'd like to take a deeper look at it, but I won't have time to get to it until the first week of December. |
cary-ilm
approved these changes
Dec 18, 2023
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Feb 13, 2024
…penEXRFileLayout.rst - 3rd attempt (AcademySoftwareFoundation#1587) * Replaced the sample exr file code blocks with a grid table formatted with bytes of the sample file in one column. The value in the second column and the third column being the description of the bytes and value. Signed-off-by: An Nguyen <annguyen@ilm.com> * * Updated so the ascii values for the bytes are aligned to each byte. * Gave the table a title and reduce the width to 50% Signed-off-by: An Nguyen <annguyen@ilm.com> * Added missing 4 bytes missing from the dataWindow value and displayWindow value Signed-off-by: An Nguyen <annguyen@ilm.com> * Added the sample.exr file Signed-off-by: An Nguyen <annguyen@ilm.com> * Annotated the attribute values more for the header. Should be a bit clearer. Signed-off-by: An Nguyen <annguyen@ilm.com> * Adding the sample.exr file was documented. Signed-off-by: An Nguyen <annguyen@ilm.com> * Added download link to the sample.exr file. Signed-off-by: An Nguyen <annguyen@ilm.com> * Move the download link above the table. Updated the paragraph before the table to describe the table Signed-off-by: An Nguyen <annguyen@ilm.com> * Move the sample.exr image into the downloads directory to match the target destination naming scheme to avoid confusion where the files go when built Signed-off-by: An Nguyen <annguyen@ilm.com> * Updated the table to annotate the type and literal as type. Signed-off-by: An Nguyen <annguyen@ilm.com> --------- Signed-off-by: An Nguyen <annguyen@ilm.com>
cary-ilm
pushed a commit
that referenced
this pull request
Feb 16, 2024
…d attempt (#1587) * Replaced the sample exr file code blocks with a grid table formatted with bytes of the sample file in one column. The value in the second column and the third column being the description of the bytes and value. Signed-off-by: An Nguyen <annguyen@ilm.com> * * Updated so the ascii values for the bytes are aligned to each byte. * Gave the table a title and reduce the width to 50% Signed-off-by: An Nguyen <annguyen@ilm.com> * Added missing 4 bytes missing from the dataWindow value and displayWindow value Signed-off-by: An Nguyen <annguyen@ilm.com> * Added the sample.exr file Signed-off-by: An Nguyen <annguyen@ilm.com> * Annotated the attribute values more for the header. Should be a bit clearer. Signed-off-by: An Nguyen <annguyen@ilm.com> * Adding the sample.exr file was documented. Signed-off-by: An Nguyen <annguyen@ilm.com> * Added download link to the sample.exr file. Signed-off-by: An Nguyen <annguyen@ilm.com> * Move the download link above the table. Updated the paragraph before the table to describe the table Signed-off-by: An Nguyen <annguyen@ilm.com> * Move the sample.exr image into the downloads directory to match the target destination naming scheme to avoid confusion where the files go when built Signed-off-by: An Nguyen <annguyen@ilm.com> * Updated the table to annotate the type and literal as type. Signed-off-by: An Nguyen <annguyen@ilm.com> --------- Signed-off-by: An Nguyen <annguyen@ilm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a pull request from the feature branch of my forked repro. This allows me to sync the main branch of my forked repro to sync any updates from the root repro.
After syncing the root repro into my fork main branch. Rebase my feature branch with main to pick up the updates. Resolve any conflicts which resolved the typo commit in README.md, as in removed that commit.
Move the download link of the sample.exr above the table.
Update the paragraph above the table to describe the table columns instead of the rows of the old code blocks.
Minor housekeeping, moving the sample.exr to the website/downloads to keep it consistent with the build/website/sphinx/_downloads directory. To avoid confusion for future additions to downloads etc.