Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-wheels.yml - add arm64 builds for macOS #1579

Merged

Conversation

barnabyrobson
Copy link
Contributor

The CI platform that builds the wheels is Intel based and by default only builds Intel wheels.

Modern Macs are all based on Apple Silicon so to support them we need to also build arm64. This is done via cross compiling.

It is not possible to test when cross compiling according to:

https://cibuildwheel.readthedocs.io/en/stable/faq/#how-to-cross-compile

The CI platform that builds the wheels is Intel based and
by default only builds Intel wheels.

Modern Macs are all based on Apple Silicon so to support them
we need to also build arm64. This is done via cross compiling.

It is not possible to test when cross compiling according to:

https://cibuildwheel.readthedocs.io/en/stable/faq/#how-to-cross-compile

Signed-off-by: Barnaby Robson <brobson@ilm.com>
@barnabyrobson
Copy link
Contributor Author

This PR is an alternative to another solution which is to choose universal builds instead.

I went with this idea because I felt it would be unacceptable to only go with universal builds.
The reason for that is that universal builds are only available for Python 3.8+ so we would be
essentially cutting off Mac users who are on 3.6 and 3.7.

However this solution has a negative which is that it makes the CI take longer.

Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cary-ilm cary-ilm merged commit 4de528d into AcademySoftwareFoundation:main Oct 14, 2023
29 checks passed
annguyen-ilm pushed a commit to annguyen-ilm/openexr that referenced this pull request Oct 24, 2023
…tion#1579)

The CI platform that builds the wheels is Intel based and
by default only builds Intel wheels.

Modern Macs are all based on Apple Silicon so to support them
we need to also build arm64. This is done via cross compiling.

It is not possible to test when cross compiling according to:

https://cibuildwheel.readthedocs.io/en/stable/faq/#how-to-cross-compile

Signed-off-by: Barnaby Robson <brobson@ilm.com>
Signed-off-by: An Nguyen <annguyen@ilm.com>
cary-ilm pushed a commit to cary-ilm/openexr that referenced this pull request Feb 13, 2024
…tion#1579)

The CI platform that builds the wheels is Intel based and
by default only builds Intel wheels.

Modern Macs are all based on Apple Silicon so to support them
we need to also build arm64. This is done via cross compiling.

It is not possible to test when cross compiling according to:

https://cibuildwheel.readthedocs.io/en/stable/faq/#how-to-cross-compile

Signed-off-by: Barnaby Robson <brobson@ilm.com>
cary-ilm pushed a commit that referenced this pull request Feb 16, 2024
The CI platform that builds the wheels is Intel based and
by default only builds Intel wheels.

Modern Macs are all based on Apple Silicon so to support them
we need to also build arm64. This is done via cross compiling.

It is not possible to test when cross compiling according to:

https://cibuildwheel.readthedocs.io/en/stable/faq/#how-to-cross-compile

Signed-off-by: Barnaby Robson <brobson@ilm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants