Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.2.1 commits and release notes #1569

Merged
merged 19 commits into from
Sep 25, 2023

Commits on Sep 23, 2023

  1. Propagate OPENEXR_INSTALL_PKG_CONFIG to internal Imath (AcademySoftwa…

    …reFoundation#1531)
    
    * Propagate OPENEXR_INSTALL_PKG_CONFIG to internal Imath
    
    If OpenEXR is installing a pkg-config file, then the internal Imath
    build (if there is one) should install it, too.
    
    Also, add an explicit release version variable to the .pc file.
    
    This is in preparation for the python wheel build to pick up the
    version settings from the pkg-config files.
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    
    * remove version= from OpenEXR.pc
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    
    ---------
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    cary-ilm committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    5240892 View commit details
    Browse the repository at this point in the history
  2. Remove check for _MSC_VER in internal_cpuid.h (AcademySoftwareFoundat…

    …ion#1528)
    
    As noted in AcademySoftwareFoundation#1445, _MSC_VER should only be used to detect msvc, not
    for Windows. The _WIN32 check should be sufficient. The extra check
    for _MSC_VER fails when cross-compiling from Linux to Windows.
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    cary-ilm committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    7b80467 View commit details
    Browse the repository at this point in the history
  3. Fix warnings in multipartExamples.cpp (AcademySoftwareFoundation#1533)

    * Fix warnings in multipartExamples.cpp
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    
    * fix indentation
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    
    ---------
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    cary-ilm committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    0650cd2 View commit details
    Browse the repository at this point in the history
  4. Fix warnings from cross-compiling with x86_64-w64-mingw32-gcc-posix (A…

    …cademySoftwareFoundation#1534)
    
    * Fix compiler warnings from x86_64-w64-mingw32-g++-posix
    
    * MSVCRT doesn't recognize printf("%l") so PRIu64 doesn't work, it
      expects "%I64u".
    
    * Add to the cases that disable a strncpy warning
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    
    * %zu for size_t
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    
    * revert attempt to fix PRIu64 warnings
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    
    * revert blank line
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    
    ---------
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    cary-ilm committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    b9140da View commit details
    Browse the repository at this point in the history
  5. Fix OPENEXR_VERSION_HEX (AcademySoftwareFoundation#1539)

    * Fix OPENEXR_VERSION_HEX
    
    * fix syntax error
    * remove unnecessary uint32_t cast
    * add validation test
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    
    * Add #if statement with OPENEXR_VERSION_HEX
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    
    ---------
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    cary-ilm committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    3073b71 View commit details
    Browse the repository at this point in the history
  6. OPENEXR_INSTALL_PKG_CONFIG is on by default, even on Windows (Academy…

    …SoftwareFoundation#1541)
    
    There seems to be no downside to generating the OpenEXR.pc file even
    on Windows, so for consistency, apply the setting to all platforms.
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    cary-ilm committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    c261f43 View commit details
    Browse the repository at this point in the history
  7. Remove SPDX license identifier in LICENSE.md

    Signed-off-by: Cary Phillips <cary@ilm.com>
    cary-ilm committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    fc993fa View commit details
    Browse the repository at this point in the history
  8. Python wheel setup gets version from OpenEXR.pc/Imath.pc (AcademySoft…

    …wareFoundation#1536)
    
    * Python wheel setup gets version from OpenEXR.pc/Imath.pc
    
    OpenEXR and Imath have indepdenent versions that may not match. The
    .pc files appear to be the simplest way to extract the versions and
    library suffixes.
    
    Running pkg-config itself doesn't work on Windows, hence the manual
    file parsing.
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    
    * =
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    
    * Remove -DOPENEXR_INSTALL_PKG_CONFIG=ON since it's now on by default
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    
    ---------
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    cary-ilm committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    4594b64 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e93131b View commit details
    Browse the repository at this point in the history
  10. Update openexr_deps.bzl (AcademySoftwareFoundation#1565)

    Signed-off-by: Vertexwahn <julian.amann@tum.de>
    Vertexwahn authored and cary-ilm committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    cdf831d View commit details
    Browse the repository at this point in the history
  11. Bazel: Improve module (AcademySoftwareFoundation#1562)

    Signed-off-by: Vertexwahn <julian.amann@tum.de>
    Vertexwahn authored and cary-ilm committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    08449f9 View commit details
    Browse the repository at this point in the history
  12. Set build-shared:OFF for Static build (AcademySoftwareFoundation#1557)

    Looks like this somehow we've been building shared when we meant to be
    building static.
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    cary-ilm committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    1312455 View commit details
    Browse the repository at this point in the history
  13. Omit OPENEXR_IMAGES_TAG from test image url if empty (AcademySoftware…

    …Foundation#1560)
    
    This allows the url for the test images to reference a local file:
    
      cmake -DOPENEXR_IMAGES_REPO=file:///my/clone/of/openexr-images -DOPENEXR_IMAGES_TAG=""
    
    which avoids the remote downloading of the test images at cmake time.
    
    Also, mention the test images in the install docs.
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    cary-ilm committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    4f9c1a3 View commit details
    Browse the repository at this point in the history
  14. Clean up handling of libdeflate when linking static (AcademySoftwareF…

    …oundation#1561)
    
    * Set EXR_DEFLATE_LIB properly for static linking
    
    This leads OpenEXRCore/CMakeLists.txt to do:
    
        target_link_libraries(OpenEXRCore PUBLIC libdeflate)
    
    instead of:
    
        target_link_libraries(OpenEXRCore PUBLIC PkgConfig::deflate)
    
    which is not recognized. With a target link library of
    `PkgConfig::deflate`, the static build of the OpenEXR libraries builds
    successfully, but configuring an application against those static
    libraries fails, saying it can't find `PkgConfig::deflate`.
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    
    * Add -ldeflate to pkgconfig for static builds
    
    When static linking and referencing an external libdeflate (i.e. not
    fetching and building internally), OpenEXR.pc needs -ldeflate.
    
    This also adds a test for this condition to the CI's validation script.
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    
    ---------
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    cary-ilm committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    7cda5f5 View commit details
    Browse the repository at this point in the history
  15. Don't trigger ci/bazel/ossfuzz builds on pushes/PRs to src/wrappers (A…

    …cademySoftwareFoundation#1532)
    
    No need to rebuild/test OpenEXR on changes to the python wheels.
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    cary-ilm committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    52835b7 View commit details
    Browse the repository at this point in the history
  16. Set minimal permissions for workflow python-wheels.yml (AcademySoftwa…

    …reFoundation#1530)
    
    The exact same changes done on other workflows through the PR AcademySoftwareFoundation#1417
    
    Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
    diogoteles08 authored and cary-ilm committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    0c69cc0 View commit details
    Browse the repository at this point in the history
  17. Release notes for 3.2.1

    Signed-off-by: Cary Phillips <cary@ilm.com>
    cary-ilm committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    eb5556d View commit details
    Browse the repository at this point in the history
  18. Fix Imf/Iex/IlmThread namespaces in python bindings and website code (A…

    …cademySoftwareFoundation#1568)
    
    * Fix Imf/Iex/IlmThread namespaces in python bindings and website code
    
    Use OPENEXR_NAMESPACE, IEX_NAMESPACE, ILMTHREAD_NAMESPACE instead of
    Imf, Iex, IlmThread, to support custom settings.
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    
    * Use Iex:: namespace in example code instead of IEX_NAMESPACE
    
    Requires this in all.cpp:
    
      namespace Iex = IEX_NAMESPACE;
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    
    * use #define Iex
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    
    * remove explicit Iex namespace
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    
    ---------
    
    Signed-off-by: Cary Phillips <cary@ilm.com>
    cary-ilm committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    31ec4c3 View commit details
    Browse the repository at this point in the history
  19. Bump version to 3.2.1

    Signed-off-by: Cary Phillips <cary@ilm.com>
    cary-ilm committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    8e1fa90 View commit details
    Browse the repository at this point in the history