Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fix to build OpenEXR_Viewers #149

Closed
wants to merge 2 commits into from
Closed

Build fix to build OpenEXR_Viewers #149

wants to merge 2 commits into from

Conversation

mikaelsundell
Copy link

Couldn't build the OpenEXR_Viewers 2.2 release with OpenEXR 2.2. Changed a few things in the cmake setup to get it running, guess I'm missing something here.

@meshula
Copy link
Contributor

meshula commented Dec 29, 2014

It might be a good idea for the OpenEXR project to publish some generic FindIlmBase and FindOpenEXR CMake scripts. CTL is broken (and you've supplied a PR for it). Alembic is broken too, I suspect across the board, there's more broken than not. An alternative to new CMake scripts would be to symlink the files back to the old names during the EXR build, but I suspect there was debate and the conclusion was to suffix versions to names to avoid version conflicts?

@mikaelsundell
Copy link
Author

I agree - everyone is doing their own cmake scripts for IlmBase and OpenEXR right now. Would be nice with an official version that supports different versions. OIIO does a good job:
https://github.com/OpenImageIO/oiio/blob/master/src/cmake/modules/FindIlmBase.cmake

It basically regex out the version numbers from OpenEXRConfig.h and and IlmBaseConfig.h and then formats to get the right syntax for the version suffix of the libraries.

I just sent an email to the Alembic list on the same subject:
https://groups.google.com/forum/#!topic/alembic-discussion/WrK6dTOfFj8

This one is even more simple, the -2_2 suffix is added in the bootstrap after the IlmMath library is given a s a parameter.

So - yes 2 official cmake scripts to find OpenEXR and IlmBase would be perfect :-)

@meshula
Copy link
Contributor

meshula commented Aug 3, 2018

I think this need was met by ecfcac7

Thanks

@meshula meshula closed this Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants