Fix cpu detection of sse2 on non-64 x86 #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code accidentally elided the i386 (i.e. non-64 bit versions of x86 compiles). This refactors and simplifies the ifdef snarl to clarify and fix that. Fixes AcademySoftwareFoundation#1459 Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
We require gcc / clang style inline asm for avx support, detecting it properly causes problems for the dwa support which uses that. Disable again. Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
meshula
approved these changes
Jun 26, 2023
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Jul 25, 2023
* Fix cpu detection of sse2 on non-64 x86 Previous code accidentally elided the i386 (i.e. non-64 bit versions of x86 compiles). This refactors and simplifies the ifdef snarl to clarify and fix that. Fixes AcademySoftwareFoundation#1459 Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Fix mismatch with windows and enable avx support check there Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Disable avx detection under msvc for now We require gcc / clang style inline asm for avx support, detecting it properly causes problems for the dwa support which uses that. Disable again. Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> --------- Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
cary-ilm
pushed a commit
that referenced
this pull request
Jul 31, 2023
* Fix cpu detection of sse2 on non-64 x86 Previous code accidentally elided the i386 (i.e. non-64 bit versions of x86 compiles). This refactors and simplifies the ifdef snarl to clarify and fix that. Fixes #1459 Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Fix mismatch with windows and enable avx support check there Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Disable avx detection under msvc for now We require gcc / clang style inline asm for avx support, detecting it properly causes problems for the dwa support which uses that. Disable again. Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> --------- Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
|
This broke the build when compiling with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code accidentally elided the i386 (i.e. non-64 bit versions of x86 compiles). This refactors and simplifies the ifdef snarl to clarify and fix that.
Fixes #1459