Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Iex test coverage #1364

Merged
merged 6 commits into from
Mar 20, 2023
Merged

Extend Iex test coverage #1364

merged 6 commits into from
Mar 20, 2023

Conversation

cary-ilm
Copy link
Member

  • better tests for exception class constructors
  • tests for math exceptions
  • tests for errno exceptions
  • fixed a 22-year old bug in throwErrnoExc(ENOCSI)

@cary-ilm
Add tests for throwErrnoExc
77a02c0 
And fixed bug in throwing ENOCSI

Signed-off-by: Cary Phillips <cary@ilm.com>
@cary-ilm
testMathExc
ec778da 
Signed-off-by: Cary Phillips <cary@ilm.com>
@cary-ilm
testMathExc
0a1a096 
Signed-off-by: Cary Phillips <cary@ilm.com>
@cary-ilm
typeinfo
17b453e 
Signed-off-by: Cary Phillips <cary@ilm.com>
@cary-ilm
fix test2
921efdf 
Signed-off-by: Cary Phillips <cary@ilm.com>
@cary-ilm
test3
5b9abf5 
Signed-off-by: Cary Phillips <cary@ilm.com>
meshula
meshula approved these changes Mar 19, 2023
View reviewed changes
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ENOSCI thing took a bit to even spot where the bug was! My brain kept auto-correcting or something ;)

lgtm

@cary-ilm
Copy link
Member Author

I won't tell you how long it took me :)

@cary-ilm cary-ilm merged commit 673205a into AcademySoftwareFoundation:main Mar 20, 2023
@cary-ilm cary-ilm added the v3.2.0 label Jul 9, 2023
@yu-re-ka yu-re-ka mentioned this pull request Sep 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meshula meshula meshula approved these changes

Assignees
No one assigned
Labels
v3.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cary-ilm @meshula