Add header files for IDEs #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
|
It would definitely be good to clean up the multiple tmpDir.h files, although since this is strictly internal to the test suite, it would be best not to further pollute ImfMisc.h, since that's included lots of places. tmpDir.h appears in OpenEXRTest, OpenEXRUtilTest, and OpenEXRFuzzTest. It's a bit sloppy, but could you leave it in OpenEXRTest and have the other directories include it via "../OpenEXRTest/tmpDir.h". |
|
Adding "../OpenEXRTest" to the include path for the other tests seems reasonable, "tmpDir.h" just contains a few macros. I'll make a separate PR for that. |
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 3, 2023
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
cary-ilm
pushed a commit
that referenced
this pull request
Mar 5, 2023
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, as a follow up to #1279, I found a couple more places where header files were missing from the CMakeLists.txt files. Adding the header files to the CMakeLists.txt files allows them to show up in IDEs.
Totally unrelated, but while I was making the changes I noticed there were three copies of the file "tmpDir.h" in the tests directories? Maybe that functionality could be refactored into "ImfMisc.h"?