Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CONTRIBUTING.md #1311

Merged

Conversation

cary-ilm
Copy link
Member

@cary-ilm cary-ilm commented Nov 9, 2022

  • Replace "make check" with "make test"

  • Remove the section on GitHub issue labels. Seemed like a good idea at the time, but the use of labels is informal enough that it doesn't really warrant description here.

  • Update rules about PR approvals

  • Mention .clang-format

Signed-off-by: Cary Phillips cary@ilm.com

* Replace "make check" with "make test"

* Remove the section on GitHub issue labels. Seemed like a good idea
  at the time, but the use of labels is informal enough that it
  doesn't really warrant description here.

* Update rules about PR approvals

* Mention .clang-format

Signed-off-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Cary Phillips <cary@ilm.com>
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall

Signed-off-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Cary Phillips <cary@ilm.com>
@cary-ilm cary-ilm merged commit 52baef1 into AcademySoftwareFoundation:main Nov 10, 2022
@cary-ilm cary-ilm deleted the contributing-doc-fix branch January 4, 2023 01:52
cary-ilm added a commit to cary-ilm/openexr that referenced this pull request Mar 3, 2023
* Clean up CONTRIBUTING.md

* Replace "make check" with "make test"

* Remove the section on GitHub issue labels. Seemed like a good idea
  at the time, but the use of labels is informal enough that it
  doesn't really warrant description here.

* Update rules about PR approvals

* Mention .clang-format

Signed-off-by: Cary Phillips <cary@ilm.com>

* don't capitalized Contributor and Committer

Signed-off-by: Cary Phillips <cary@ilm.com>

* More formatting fixes, and remove the tarball signing instructions

Signed-off-by: Cary Phillips <cary@ilm.com>

* Formatting fixes in GOVERNANCE.md

Signed-off-by: Cary Phillips <cary@ilm.com>

Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm added a commit that referenced this pull request Mar 5, 2023
* Clean up CONTRIBUTING.md

* Replace "make check" with "make test"

* Remove the section on GitHub issue labels. Seemed like a good idea
  at the time, but the use of labels is informal enough that it
  doesn't really warrant description here.

* Update rules about PR approvals

* Mention .clang-format

Signed-off-by: Cary Phillips <cary@ilm.com>

* don't capitalized Contributor and Committer

Signed-off-by: Cary Phillips <cary@ilm.com>

* More formatting fixes, and remove the tarball signing instructions

Signed-off-by: Cary Phillips <cary@ilm.com>

* Formatting fixes in GOVERNANCE.md

Signed-off-by: Cary Phillips <cary@ilm.com>

Signed-off-by: Cary Phillips <cary@ilm.com>
@cary-ilm cary-ilm added the v3.1.6 label Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants