-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up CONTRIBUTING.md #1311
Merged
cary-ilm
merged 4 commits into
AcademySoftwareFoundation:main
from
cary-ilm:contributing-doc-fix
Nov 10, 2022
Merged
Clean up CONTRIBUTING.md #1311
cary-ilm
merged 4 commits into
AcademySoftwareFoundation:main
from
cary-ilm:contributing-doc-fix
Nov 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace "make check" with "make test" * Remove the section on GitHub issue labels. Seemed like a good idea at the time, but the use of labels is informal enough that it doesn't really warrant description here. * Update rules about PR approvals * Mention .clang-format Signed-off-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Cary Phillips <cary@ilm.com>
meshula
reviewed
Nov 9, 2022
meshula
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm overall
Signed-off-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Cary Phillips <cary@ilm.com>
meshula
approved these changes
Nov 10, 2022
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 3, 2023
* Clean up CONTRIBUTING.md * Replace "make check" with "make test" * Remove the section on GitHub issue labels. Seemed like a good idea at the time, but the use of labels is informal enough that it doesn't really warrant description here. * Update rules about PR approvals * Mention .clang-format Signed-off-by: Cary Phillips <cary@ilm.com> * don't capitalized Contributor and Committer Signed-off-by: Cary Phillips <cary@ilm.com> * More formatting fixes, and remove the tarball signing instructions Signed-off-by: Cary Phillips <cary@ilm.com> * Formatting fixes in GOVERNANCE.md Signed-off-by: Cary Phillips <cary@ilm.com> Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
added a commit
that referenced
this pull request
Mar 5, 2023
* Clean up CONTRIBUTING.md * Replace "make check" with "make test" * Remove the section on GitHub issue labels. Seemed like a good idea at the time, but the use of labels is informal enough that it doesn't really warrant description here. * Update rules about PR approvals * Mention .clang-format Signed-off-by: Cary Phillips <cary@ilm.com> * don't capitalized Contributor and Committer Signed-off-by: Cary Phillips <cary@ilm.com> * More formatting fixes, and remove the tarball signing instructions Signed-off-by: Cary Phillips <cary@ilm.com> * Formatting fixes in GOVERNANCE.md Signed-off-by: Cary Phillips <cary@ilm.com> Signed-off-by: Cary Phillips <cary@ilm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace "make check" with "make test"
Remove the section on GitHub issue labels. Seemed like a good idea at the time, but the use of labels is informal enough that it doesn't really warrant description here.
Update rules about PR approvals
Mention .clang-format
Signed-off-by: Cary Phillips cary@ilm.com