Match cpp header checks #1244
Merged
Match cpp header checks #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t header parse Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
- adds a flags member to the context initializer - adds a backwards compatibility struct definition - refactors common init code to helper routine to handle arg versions Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
…printer Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
meshula
approved these changes
Mar 31, 2022
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Apr 2, 2022
* Add flags for header parsing options, function to restore after silent header parse Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Use new context flags for strict header and silent parsing Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Expose strict and silent header parsing flags - adds a flags member to the context initializer - adds a backwards compatibility struct definition - refactors common init code to helper routine to handle arg versions Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Add strict / silent logic to c-only metadata example header parser / printer Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> Signed-off-by: Cary Phillips <cary@ilm.com>
Merged
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Apr 2, 2022
* Add flags for header parsing options, function to restore after silent header parse Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Use new context flags for strict header and silent parsing Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Expose strict and silent header parsing flags - adds a flags member to the context initializer - adds a backwards compatibility struct definition - refactors common init code to helper routine to handle arg versions Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Add strict / silent logic to c-only metadata example header parser / printer Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
pushed a commit
that referenced
this pull request
Apr 7, 2022
* Add flags for header parsing options, function to restore after silent header parse Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Use new context flags for strict header and silent parsing Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Expose strict and silent header parsing flags - adds a flags member to the context initializer - adds a backwards compatibility struct definition - refactors common init code to helper routine to handle arg versions Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Add strict / silent logic to c-only metadata example header parser / printer Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> Signed-off-by: Cary Phillips <cary@ilm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues noticed by PhilB around inconsistencies between what the c++ library would allow vs. the original "strict" mode of the C core. This adds (in a backwards compatible manner) flags to the context creation that allows the user to enable strict header parsing to restore the original behavior, and optionally a new "silent" parse mode that will suspend calls to the logging interface while parsing the header