Extend multipart RgbaInputFile API #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balazs OROSZI <orobalage@gmail.com>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
|
This all looks fine to me, but is it worth adding a reference to this in the documentation, since it's new functionality? |
|
It is worth documenting, yes. I don't see any documentation of |
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Jan 19, 2022
* RgbaInputFile: Multipart support test Signed-off-by: Balazs OROSZI <orobalage@gmail.com> * extend multipart RgbaInputFile API Signed-off-by: Peter Hillman <peterh@wetafx.co.nz> * remove RgbaInputFile friend from MultiPartInputFile Signed-off-by: Peter Hillman <peterh@wetafx.co.nz> * fix test failure: test all parts for completion Signed-off-by: Peter Hillman <peterh@wetafx.co.nz> * add missing export to ImfRgbaFile.h Signed-off-by: Peter Hillman <peterh@wetafx.co.nz> * add multipart Rgba support to Imf::CheckFile Signed-off-by: Peter Hillman <peterh@wetafx.co.nz> Co-authored-by: Balazs OROSZI <orobalage@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #1194 with more functionality for reading multipart files using RgbaInputFile:
I'm not 100% sure that MultiPartInputFile + InputPart handles weird edge cases identically to InputFile, so some semi-broken files may be handled differently.