v3.1.3 patches #1181
Merged
v3.1.3 patches #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
NB: This changes the ABI of ImfHeader, so must be a 3.2 feature Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
with unit tests Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
…oundation#1145) Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
…C core Also adds the mechanism to the context initializer Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
…ame time Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Also, comment the more complex workaround to get to a stable static destruction state when compiling to static libraries Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
…dation#1161) Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
…n#1160) Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
…dation#1163) Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
… coordinate (AcademySoftwareFoundation#1164) oss fuzz 39399 Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
…dation#1150) Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
…reFoundation#1165) normal file semantics will return 0 for this indicating EOF Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
* fix dataWindow width signed calc * use int64_t in CheckFile loop to prevent wraparound * tile indexes should start from 0 not datawin.min Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
…flow (AcademySoftwareFoundation#1169) OSS Fuzz 39522, 39526, 39529 Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
* Avoid uninitialized memory error in non-sanitized libstdc++ Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Refactor attribute size checks for large attribute chunks, clear memory earlier, centralize file size check, fix uninitialized memory error with memory sanitizer Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Fix typo Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
…areFoundation#1125) In my test of 18 various exr files (total raw data size 1057MB): - zip 6: 2.452x ratio, 206MB/s compression - zip 4: 2.421x ratio, 437MB/s compression So a tiny drop of compression ratio, but compression is more than 2x faster. This makes writing zip faster than writing uncompressed (386MB/s). Decompression speed unaffected. Signed-off-by: Aras Pranckevicius <aras@unity3d.com>
* Fix issues with fuzz test driver - Adds a (disabled) error handler print to make th test cases easier to part - Fixes an initialization of buffers to use the better half - mark a couple of functions internal (static) Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Add chunk for offsets in chunk table to be (somewhat validate) Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Clarify comment, simplify logic check Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Add check in mirror decode pipeline for alloc of 0 bytes Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Adjust logic so we can handle single scanline compression with image sampling Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * switch to controlling prints for checking behind a getenv Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
* Remove local copies of outdated CLA's Signed-off-by: Cary Phillips <cary@ilm.com>
…ation#1177) (AcademySoftwareFoundation#1178) Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Signed-off-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Cary Phillips <cary@ilm.com>
|
Hi, please don't release until we get a fix for the broken deep reads with the core library that was caused by #1169. |
|
Yes, just getting it started. |
When we started core, there was a thought to allow an empty image to enable a metadata part. However, this needs wider support and causes regressions from the existing c++ behavior Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
…ySoftwareFoundation#1185) Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
…cademySoftwareFoundation#1183) Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
…eFoundation#1184) This fixes an issue when the y_sampling is larger than the height of a chunk (and the height is not 1). Further, adds casts, use larger type to avoid overflow Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
…ion#1187) Accidentally giving a folder name to the program exposed that the c++ library returns very large results for seeking to the end of a directory file node, handle and return quickly Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
…ation#1180) Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
- Multiple Linux builds only for VFXP-2021 (current). - Single Linux build for other VFX platform years. - Add Linux legacy C++11 build. - Update Mac and Windows builds for VFXP-2021/2022 Signed-off-by: Christina Tempelaar-Lietz <xlietz@gmail.com>
Signed-off-by: Cary Phillips <cary@ilm.com>
meshula
approved these changes
Oct 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked commits for v3.1.3. See CHANGES.md for the list of PR's.
This is a first pass, we can add further changes to it before merging.
Also, we agreed to bend the libtool versioning rules and call the library version 30.3.0 (v3.1.2 was 30.2.0), even though strictly speaking the revision should be bumped because we added to the API. But v3.1.3 should be drop-in compatible with v3.1.2 (even with the compression level changes).