fix/extend part number validation in MultiPart methods #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
meshula
approved these changes
Jun 4, 2021
cary-ilm
reviewed
Jun 9, 2021
| @@ -186,6 +186,10 @@ template DeepTiledInputFile* MultiPartInputFile::getInputPart<DeepTiledInputFile | |||
| InputPartData* | |||
| MultiPartInputFile::getPart(int partNumber) | |||
| { | |||
| if(partNumber<0 || partNumber >= _data->_headers.size()) | |||
There was a problem hiding this comment.
Is this necessary? Won't the call to getPart(partNumber) below check for a valid partnumber?
There was a problem hiding this comment.
Good point. That test is now removed
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
meshula
approved these changes
Jun 11, 2021
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Jun 23, 2021
…reFoundation#1038) * fix/extend part number validation in MultiPart methods Signed-off-by: Peter Hillman <peterh@wetafx.co.nz> * remove extraneous test Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
cary-ilm
pushed a commit
that referenced
this pull request
Jun 30, 2021
* fix/extend part number validation in MultiPart methods Signed-off-by: Peter Hillman <peterh@wetafx.co.nz> * remove extraneous test Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1031
Adds extra bounds checks to MultiPartInputFile and MultiPartOutputFile methods that take part indexes, and fixes an off-by-one in an existing check
Signed-off-by: Peter Hillman peterh@wetafx.co.nz