Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for Bazel build support #1015

Merged
merged 3 commits into from
May 10, 2021
Merged

Improvements for Bazel build support #1015

merged 3 commits into from
May 10, 2021

Conversation

Vertexwahn
Copy link
Contributor

@Vertexwahn Vertexwahn commented May 8, 2021

Some improvements for Bazel build experience. Only changes to Bazel build files.

  • Pin Imath version to 3.0.1 (instead of Imath 3.0.0 beta)
  • Add comments for treating compile warnings as errors
  • Improve config headers for Imath

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 8, 2021

CLA Signed

The committers are authorized under a signed CLA.

Signed-off-by: Vertexwahn <julian.amann@tum.de>
Signed-off-by: Vertexwahn <julian.amann@tum.de>
@Vertexwahn Vertexwahn closed this May 8, 2021
@Vertexwahn Vertexwahn reopened this May 8, 2021
Signed-off-by: Vertexwahn <julian.amann@tum.de>
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cary-ilm cary-ilm merged commit 9709f05 into AcademySoftwareFoundation:master May 10, 2021
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches Cary's latest changes to CMake vis a vis versioning, although I don't see anything around soversion, is that a thing in a Bazel build?

cary-ilm pushed a commit to cary-ilm/openexr that referenced this pull request May 13, 2021
* Pin Imath version to 3.0.1 (instead of Imath 3.0.0 beta)

Signed-off-by: Vertexwahn <julian.amann@tum.de>

* Add comments for treating compile warnings as errors

Signed-off-by: Vertexwahn <julian.amann@tum.de>

* Improve config headers for Imath

Signed-off-by: Vertexwahn <julian.amann@tum.de>
@Vertexwahn
Copy link
Contributor Author

Currently, the Bazel version of OpenEXR is only linked statically - so there is currently no soversion for the Bazel build.

cary-ilm pushed a commit to cary-ilm/openexr that referenced this pull request May 17, 2021
* Pin Imath version to 3.0.1 (instead of Imath 3.0.0 beta)

Signed-off-by: Vertexwahn <julian.amann@tum.de>

* Add comments for treating compile warnings as errors

Signed-off-by: Vertexwahn <julian.amann@tum.de>

* Improve config headers for Imath

Signed-off-by: Vertexwahn <julian.amann@tum.de>
Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm pushed a commit that referenced this pull request May 17, 2021
* Pin Imath version to 3.0.1 (instead of Imath 3.0.0 beta)

Signed-off-by: Vertexwahn <julian.amann@tum.de>

* Add comments for treating compile warnings as errors

Signed-off-by: Vertexwahn <julian.amann@tum.de>

* Improve config headers for Imath

Signed-off-by: Vertexwahn <julian.amann@tum.de>
Signed-off-by: Cary Phillips <cary@ilm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants