Move qualifying GroupData params onto stack #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chellmuth
force-pushed
the
opt-groupdata
branch
from
18a54a6
to
a608ca6
Compare
|
This looks very good to me! |
aconty
reviewed
Aug 10, 2023
AlexMWells
reviewed
Aug 14, 2023
|
As this seems useful change in general, would be good to update batched version to make the same type of change (actually should looks pretty much identical) |
Yep, happy to port this over. |
|
Updated with batched implementation. I'm relying on the Github CI for testing. |
|
Chris, you can build and test batched mode at work. Ask me how tomorrow. |
AlexMWells
reviewed
Aug 23, 2023
chellmuth
force-pushed
the
opt-groupdata
branch
from
9e200e7
to
e9cba39
Compare
AlexMWells
reviewed
Aug 23, 2023
Signed-off-by: Chris Hellmuth <chellmuth@gmail.com>
Signed-off-by: Chris Hellmuth <chellmuth@gmail.com>
Signed-off-by: Chris Hellmuth <chellmuth@gmail.com>
Signed-off-by: Chris Hellmuth <chellmuth@gmail.com>
Signed-off-by: Chris Hellmuth <chellmuth@gmail.com>
Signed-off-by: Chris Hellmuth <chellmuth@gmail.com>
Signed-off-by: Chris Hellmuth <chellmuth@gmail.com>
Signed-off-by: Chris Hellmuth <chellmuth@gmail.com>
lgritz
force-pushed
the
opt-groupdata
branch
from
02b66b2
to
ea1a496
Compare
lgritz
merged commit d4faecd
into
AcademySoftwareFoundation:main
22 of 23 checks passed
chellmuth
pushed a commit
to chellmuth/OpenShadingLanguage
that referenced
this pull request
Sep 6, 2024
* build(deps): Raise minimum CMake dependency from 3.12 to 3.15 (AcademySoftwareFoundation#1724) * Change RendererServices::get_texture_handle back to ustring (AcademySoftwareFoundation#1726) * The recently added SS::find_symloc can have const args (AcademySoftwareFoundation#1723) * perf(gpu): Move qualifying GroupData params onto stack (AcademySoftwareFoundation#1710) * OptiX PTX pipeline overhaul (AcademySoftwareFoundation#1680) * Fix default fmt logic changing in latest openimageio release (AcademySoftwareFoundation#1725) * feat: Add API for building attribute getter free functions. (AcademySoftwareFoundation#1704) * fix: Handle mixed string casting that plagues optix codegen (AcademySoftwareFoundation#1718) * Rs fmt specification - Journaling Algorithm for error, warning, fprintf (AcademySoftwareFoundation#1702)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On SPI Arnold, we are seeing GroupData as a bottleneck for GPU performance. Regardless of whether the buffer is backed by local or global memory, it's off-chip and slow to access.
This change moves qualifying parameters out of the GroupData struct and onto the stack. On GPU this makes those parameters more likely to be stored in registers, leading to better performance.
Qualifying parameter details
The qualifying parameters are all the output parameters minus three exceptions.
A typical output parameter's lifetime is scoped to the execution of the instance it is associated with. The parameter is initialized at the beginning of instance execution, accessed during the body of the instance, and after the instance body its final state is broadcast to all its downstream connections. This lifetime makes output parameters a good fit for stack storage.
The three exceptions:
These are all identifiable at code generation time and can be flagged as disqualifying.
Improvements
On internal scenes, this change improves performance by about 15% on GPU. On CPU there aren't any performance regressions, but we don't see significant gains either. It also improves ptx generation and compilation by about 10%, and slightly lowers our memory footprint due to the GroupData size reduction.
Tests
Exceptions 2 & 3 are covered by existing tests. A new test is added for exception 1, and for the case of successful optimization. This patch was also run through our internal shading testsuite.
Checklist: