fix: Have ReParameter only copy data when it changes #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For GPU in particular, this prevents needless transfers to the device when no values actually change. Also, keep track of some statistics about how much ReParameter is being used. (Which also help to verify that this change works as intended.) Signed-off-by: Larry Gritz <lg@larrygritz.com>
aconty
approved these changes
Jun 14, 2023
chellmuth
pushed a commit
to chellmuth/OpenShadingLanguage
that referenced
this pull request
Sep 6, 2024
* fix: Have ReParameter only copy data when it changes (AcademySoftwareFoundation#1698) * gpu: OptiX direct callable API that owns groupdata buffer (AcademySoftwareFoundation#1683) See merge request spi/dev/3rd-party/osl-feedstock!51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For GPU in particular, this prevents needless transfers to the device when no values actually change.
Also, keep track of some statistics about how much ReParameter is being used. (Which also helps to verify that this change works as intended.)