Build: Fix cuda compilation flags for LLVM 15 #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We missed this spot in #1592 |
For LLVM 15+, we need to disable opaque pointers. We did this for regular bitcode generation in llvm_macros.cmake, but neglected to make the corresponding change for copmiling to ptx in cuda_macros.cmake. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Apr 5, 2023
…ion#1659) For LLVM 15+, we need to disable opaque pointers. We did this for regular bitcode generation in llvm_macros.cmake, but neglected to make the corresponding change for copmiling to ptx in cuda_macros.cmake. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
that referenced
this pull request
Apr 14, 2023
For LLVM 15+, we need to disable opaque pointers. We did this for regular bitcode generation in llvm_macros.cmake, but neglected to make the corresponding change for copmiling to ptx in cuda_macros.cmake. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For LLVM 15+, we need to disable opaque pointers. We did this for regular bitcode generation in llvm_macros.cmake, but neglected to make the corresponding change for compiling to ptx in cuda_macros.cmake.