-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed snprintf formatting to satisfy some compilers. #1640
Changed snprintf formatting to satisfy some compilers. #1640
Conversation
|
698135e
to
a8c22f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow, yes. Thanks for the fix.
Can you please get the CLA squared away, and then I'll merge this.
Signed-off-by: Peter Ellerington <elleringtonp@gmail.com>
a8c22f6
to
5a3bb71
Compare
Okay, I think I've done everything now. I've made some other modifications to make integrating my renderer easier. Let me know if your interested! |
Sure, what other modifications did you have in mind? |
The main change I added was a optional register closure which lets that closure allocate with a unique function. It's slightly more work because the renderer needs to implement a function for each closure and copy the arguments more manually, but there's much more freedom. It let me do processing/interfacing with my renderer memory directly in that function (rather than storing args then looping back over everything after OSL had run). |
…reFoundation#1640) Signed-off-by: Peter Ellerington <elleringtonp@gmail.com>
Signed-off-by: Peter Ellerington elleringtonp@gmail.com
Description
When building OSL my compiler (GCC 11.3 on Ubuntu) was complaining about these snprintfs format strings not being a string literal.
Writing them to a "%s" seems to satisfy it and should produce the same result.
Tests
no changes in tests
Checklist: