[image output] Initialize pixels of partial tile conversion buffer. #4462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgritz
reviewed
Sep 29, 2024
When writing a partial tile, the unused pixels still go through float conversion. This means, that floating point operations are done on uninitialized data. This can easily lead to NaN and to floating point exceptions, if those were to be enabled. This change will set the shared buffer used for all partial tiles to all zero pixels. Tested by running valgrind before and after the change FIXES: AcademySoftwareFoundation#4461 Signed-off-by: Bram Stolk <b.stolk@gmail.com>
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 1, 2024
…AcademySoftwareFoundation#4462) When writing a partial tile, the unused pixels still go through float conversion. This means, that floating point operations are done on uninitialized data. This can easily lead to NaN and to floating point exceptions, if those were to be enabled. This change will set the shared buffer used for all partial tiles to all zero pixels. Tested by running valgrind before and after the change FIXES: AcademySoftwareFoundation#4461 Signed-off-by: Bram Stolk <b.stolk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing a partial tile, the unused pixels still go through float conversion.
This means, that floating point operations are done on uninitialized data.
This can easily lead to NaN and to floating point exceptions, if those were to be enabled.
This change will set the shared buffer used for all partial tiles to all zero pixels.
Tested by running valgrind before and after the change
FIXES: #4461
Description
Tests
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.