api: Fold span_util.h contents into span.h #4402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
span_util.h is relatively new. I'm honestly no longer sure why I thought it was necessary to make a second file, but so little is in it that I now believe its contents should be folded into span.h to keep all the span-related definitions in once place. It's just not big enough to need to be divided into several headers. Signed-off-by: Larry Gritz <lg@larrygritz.com>
|
No objections all week -> merging |
zachlewis
pushed a commit
to zachlewis/OpenImageIO
that referenced
this pull request
Sep 16, 2024
…#4402) span_util.h is relatively new. I'm honestly no longer sure why I thought it was necessary to make a second file, but so little is in it that I now believe its contents should be folded into span.h to keep all the span-related definitions in once place. It's just not big enough to need to be divided into several headers. Signed-off-by: Larry Gritz <lg@larrygritz.com> Signed-off-by: Zach Lewis <zachcanbereached@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
span_util.h is relatively new. I'm honestly no longer sure why I thought it was necessary to make a second file, but so little is in it that I now believe its contents should be folded into span.h to keep all the span-related definitions in once place. It's just not big enough to need to be divided into several headers.