Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Raise libheif minimum to 1.11 #4380

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Aug 14, 2024

This version dates from early 2021 (so still supporting back 3.5 years).

The reason for the bump is to simplify a bit on our part and avoid older versions known to be broken or lacking certain features.

This is for master/2.6/3.0 only, will not be backported to 2.5, since we never raise minimum dependencies in already-released branches.

This version dates from early 2021 (so still supporting back 3.5 years).

The reason for the bump is to simplify a bit on our part and avoid
older versions known to be broken or lacking certain features.

This is for master/2.6/3.0 only, will not be backported to 2.5, since
we never raise minimum dependencies in already-released branches.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Copy link
Contributor

@jessey-git jessey-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There 2 additional LIBHEIF_HAVE_VERSION checks that can be removed in heifoutput.cpp as well.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
@lgritz
Copy link
Collaborator Author

lgritz commented Aug 15, 2024

There 2 additional LIBHEIF_HAVE_VERSION checks that can be removed in heifoutput.cpp as well.

Right, thanks for the reminder.

Copy link
Contributor

@jessey-git jessey-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approving though watch-out for the clang-format error now.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
@lgritz lgritz merged commit 611f98a into AcademySoftwareFoundation:master Aug 15, 2024
26 checks passed
@lgritz lgritz deleted the lg-heif branch August 15, 2024 23:04
zachlewis pushed a commit to zachlewis/OpenImageIO that referenced this pull request Sep 16, 2024
…#4380)

This version dates from early 2021 (so still supporting back 3.5 years).

The reason for the bump is to simplify a bit on our part and avoid older
versions known to be broken or lacking certain features.

This is for master/2.6/3.0 only, will not be backported to 2.5, since we
never raise minimum dependencies in already-released branches.

---------

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Zach Lewis <zachcanbereached@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants