Add missing includes to libutil CMake target. #4306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgritz
requested changes
Jun 22, 2024
…OpenImageIO_BUILD_MISSING_DEPS=all Signed-off-by: kuba <kuba456@gmail.com>
kaarrot
force-pushed
the
libuitil_missing_local_includes
branch
from
bce8b8b
to
9d5c03a
Compare
lgritz
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation of 4305 (Add extra step to Makefile config target to force CMake to rescan).
The error occurs when configuring with
make OpenImageIO_BUILD_MISSING_DEPS=alloption which fails the build aslibuitildoes not have./dep/dist/includeon the path.The original solution was to rerun cmake and let it rescan paths. This step was only required to run once - after the initial CMake configuration step. This kind off worked but I'm still unsure why. So instead of that we can just add the missing location to CMakeLists.