fix(fmath.h): One more fast_exp fix #4275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR 4268, I accidentally changed the clause about things seeming buggy with older MSVS. I'm just putting things back the way they were. Signed-off-by: Larry Gritz <lg@larrygritz.com>
ThiagoIze
approved these changes
May 26, 2024
|
I think I was hoping that my last fix took care of this, too, but apparently not, and it's a different symptom than what got fixed with the undefined behvaior fix. It's hard to reproduce, and only on Windows while using the older MSVS (whereas the other easily reproduced in gcc as well), so I think this one really is a compiler bug, but I admit that my confidence in that claim is lower than it was before, only because the other thing did also affect fast_exp. But I can't find any identifiable problems, so the only plan I have at the moment is disabling this one thing on the one older compiler that is problematic, unless/until it reproduces anywhere else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #4268, I accidentally changed the clause addressing what is seemingly a bug with older MSVS. I'm just putting things back the way they were. It's not a new change, just restoring this line closer to the way it was about 3 commits back.