dev: Add Strutil::eval_as_bool #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Larry Gritz <lg@larrygritz.com>
jessey-git
reviewed
May 1, 2024
| @@ -1137,7 +1137,7 @@ control_if(Oiiotool& ot, cspan<const char*> argv) | |||
| if (ot.running()) { | |||
| // string_view command = ot.express(argv[0]); | |||
| string_view value = ot.express(argv[1]); | |||
| cond = eval_as_bool(value); | |||
| cond = Strutil::eval_as_bool(value); | |||
There was a problem hiding this comment.
There's a few remaining uses of the file-local eval_as_bool along with the old implementation itself. Were there reasons to leave those behind?
There was a problem hiding this comment.
There's an unrelated PR coming on the heels of that where they will get fixed, but I couldn't cleanly separate those out of the other changes.
jessey-git
approved these changes
May 1, 2024
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
May 16, 2024
Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
May 18, 2024
Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.