Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Make span default ctr and assignment be = default #4198

Merged
merged 2 commits into from
Mar 24, 2024
Merged

refactor: Make span default ctr and assignment be = default #4198

merged 2 commits into from
Mar 24, 2024

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Mar 23, 2024

Minor simplification.

@lgritz
refactor: Make span default ctr and assignment be = default
0a4d996 
Signed-off-by: Larry Gritz <lg@larrygritz.com>
ThiagoIze
ThiagoIze approved these changes Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@ThiagoIze ThiagoIze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. You could mark it noexcept if it's important to you that you perfectly match std::span.

src/include/OpenImageIO/span.h Show resolved Hide resolved
@lgritz
Mark several additional span methods as noexcept
1c026d5 
Signed-off-by: Larry Gritz <lg@larrygritz.com>
@lgritz lgritz merged commit 4dc04a2 into AcademySoftwareFoundation:master Mar 24, 2024
27 checks passed
@lgritz lgritz deleted the lg-spantriv branch March 24, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThiagoIze ThiagoIze ThiagoIze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgritz @ThiagoIze