int(simd.h): Make the simd types trivially_copyable #4173
Conversation
Basically, this is a way of saying memcpy of any of these simd types is fine. It doesn't matter a lot for OIIO itself, but it helps quiet some static analysis warnings for OSL. Signed-off-by: Larry Gritz <lg@larrygritz.com>
|
Could the approach from #4110 (comment) be used? |
I think that can't work in this case (I tried) because these types contain a union. I've tried a bunch of different things, and I can't seem to coax C++ into figuring it out on its own for these oddball types, even though we humans know that it's just memory and are indeed trivially copyable. |
|
In my quick test it seems to work: https://gcc.godbolt.org/z/bdxYbY7dv (toggle the #if to see the assert fail and then pass with the |
|
Ok, let me try that approach and see if it works everywhere. Maybe I am either misremembering what trouble I ran into last time, or it's only on some combination of compilers. Thanks for prodding me to reexamine the assumptions. |
|
Just as an update, looking into this sent me down a rathole that might end up being a much larger overhaul to the simd internals. Will post an update in a few days, I'm working on it in dribs and drabs. |
|
I'm going to withdraw this PR and start a new one, I got this working in a better way. |
Basically, this is a way of saying memcpy of any of these simd types is fine. It doesn't matter a lot for OIIO itself, but it helps quiet some static analysis warnings for OSL.