build: Fixes for DCMTK #4147
Merged
build: Fixes for DCMTK #4147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It somehow escaped our notice, but not only does DCMTK have an exported config, but also CMake itself has a FindDCMTK.cmake module. So get rid of ours, and prefer the config if available. This is hoped to solve some edge cases for finding and using this library properly. Fixes 4146 (I hope?) Signed-off-by: Larry Gritz <lg@larrygritz.com>
|
No objections for 2 weeks -> merging |
lgritz
merged commit 414f953
into
AcademySoftwareFoundation:master
24 of 25 checks passed
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Feb 20, 2024
It somehow escaped our notice, but not only does DCMTK have an exported config, but also CMake itself has a FindDCMTK.cmake module. So get rid of ours, and prefer the config if available. This is hoped to solve some edge cases for finding and using this library properly. Fixes AcademySoftwareFoundation#4146 (I hope?) Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It somehow escaped our notice, but not only does DCMTK have an exported config, but also CMake itself has a FindDCMTK.cmake module. So get rid of ours, and prefer the config if available. This is hoped to solve some edge cases for finding and using this library properly.
Fixes #4146
(I hope?)