Fixes to reduce problems identified by static analysis #4113

lgritz · 2024-01-17T06:05:17Z

pngoutput.cpp: Catch possible exceptions.
printinfo.cpp: assertions to assure we don't dereference a null pointer.
testtex.cpp: make sure allocated chunk is initialized
WriterInternal.h: Catch condition that could lead to buffer underflow.
imagebufalgo_mad.cpp: Simplify pointless clause. The prior test was redundant. Since a few lines above, if B was an image but A was not, we swapped to ensure that A was always an image. So here, we can just test A to know for sure that at least one of them is an image. That makes the test here simpler, but it also makes it more clear to static analysis that from this point forward, A can't be nullptr.

* pngoutput.cpp: Catch possible exceptions. * printinfo.cpp: assertions to assure we don't dereference a null pointer. * testtex.cpp: make sure allocated chunk is initialized * WriterInternal.h: Catch condition that could lead to buffer underflow. * imagebufalgo_mad.cpp: Simplify pointless clause. The prior test was redundant. Since a few lines above, if B was an image but A was not, we swapped to ensure that A was always an image. So here, we can just test A to know for sure that at least one of them is an image. That makes the test here simpler, but it also makes it more clear to static analysis that from this point forward, A can't be nullptr. Signed-off-by: Larry Gritz <lg@larrygritz.com>

lgritz · 2024-01-17T06:06:20Z

This is a reposting of botched PR #4112. Please see there for the review discussion and approval.

…reFoundation#4113) * pngoutput.cpp: Catch possible exceptions. * printinfo.cpp: assertions to assure we don't dereference a null pointer. * testtex.cpp: make sure allocated chunk is initialized * WriterInternal.h: Catch condition that could lead to buffer underflow. * imagebufalgo_mad.cpp: Simplify pointless clause. The prior test was redundant. Since a few lines above, if B was an image but A was not, we swapped to ensure that A was always an image. So here, we can just test A to know for sure that at least one of them is an image. That makes the test here simpler, but it also makes it more clear to static analysis that from this point forward, A can't be nullptr. Signed-off-by: Larry Gritz <lg@larrygritz.com>

…reFoundation#4113) * pngoutput.cpp: Catch possible exceptions. * printinfo.cpp: assertions to assure we don't dereference a null pointer. * testtex.cpp: make sure allocated chunk is initialized * WriterInternal.h: Catch condition that could lead to buffer underflow. * imagebufalgo_mad.cpp: Simplify pointless clause. The prior test was redundant. Since a few lines above, if B was an image but A was not, we swapped to ensure that A was always an image. So here, we can just test A to know for sure that at least one of them is an image. That makes the test here simpler, but it also makes it more clear to static analysis that from this point forward, A can't be nullptr. Signed-off-by: Larry Gritz <lg@larrygritz.com> Signed-off-by: Peter Kovář <peter.kovar@reflexion.tv>

lgritz merged commit cfb7918 into AcademySoftwareFoundation:master Jan 17, 2024
24 of 25 checks passed

lgritz deleted the lg-sonar-1 branch January 17, 2024 06:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes to reduce problems identified by static analysis #4113

Fixes to reduce problems identified by static analysis #4113

lgritz commented Jan 17, 2024

lgritz commented Jan 17, 2024

Fixes to reduce problems identified by static analysis #4113

Fixes to reduce problems identified by static analysis #4113

Conversation

lgritz commented Jan 17, 2024

lgritz commented Jan 17, 2024