Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): Make sure C++ knows ustring & ustringhash are trivially copyable #4110

Merged
merged 2 commits into from
Jan 17, 2024
Merged

fix(dev): Make sure C++ knows ustring & ustringhash are trivially copyable #4110

merged 2 commits into from
Jan 17, 2024

Commits on Jan 13, 2024

  1. Make sure C++ knows ustring & ustringhash are trivially copyable 

    Signed-off-by: Larry Gritz <lg@larrygritz.com>
    @lgritz
    lgritz committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    d3c9edc View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Refactor ustring and ustringhash 

    * Use default implementations of copy ctr, destructor, and assignment
  from ustring. This allows ustring & ustringhash to be recognized as
  being a variety of flavors of trivially constructible, copyable, and
  destructible.

* It seems that the assignment operators were returning `const &`
  whereas it's more typical to return `&`, so now we do.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
    @lgritz
    lgritz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    98fca20 View commit details
    Browse the repository at this point in the history