Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Improve perf of IBA::channels in-place operation #4088

Merged
merged 1 commit into from
Dec 25, 2023
Merged

perf: Improve perf of IBA::channels in-place operation #4088

merged 1 commit into from
Dec 25, 2023

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Dec 23, 2023

For the in-place case (where src and dst refer to the same IB), we were doing an unnecessary full-image copy.

@lgritz
perf: Improve perf of IBA::channels in-place operation
6a4b8fc 
For the in-place case (where src and dst refer to the same IB), we
were doing an unnecessary full-image copy.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
ThiagoIze
ThiagoIze approved these changes Dec 25, 2023
View reviewed changes
Copy link
Collaborator

@ThiagoIze ThiagoIze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we had a copy and the writing done by channels(). Now we just have the writing by channels() and the internal data then gets moved instead of copied, so this looks correct and yes should be faster.

@lgritz lgritz merged commit 406704d into AcademySoftwareFoundation:master Dec 25, 2023
25 checks passed
@lgritz lgritz deleted the lg-chperf branch December 25, 2023 23:58
lgritz added a commit to lgritz/OpenImageIO that referenced this pull request Dec 26, 2023
@lgritz
perf: Improve perf of IBA::channels in-place operation (AcademySoftwa…
dec7810 
…reFoundation#4088)

For the in-place case (where src and dst refer to the same IB), we were
doing an unnecessary full-image copy.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
1div0 pushed a commit to 1div0/OpenImageIO that referenced this pull request Feb 24, 2024
@lgritz @1div0
perf: Improve perf of IBA::channels in-place operation (AcademySoftwa…
3037b71 
…reFoundation#4088)

For the in-place case (where src and dst refer to the same IB), we were
doing an unnecessary full-image copy.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Peter Kovář <peter.kovar@reflexion.tv>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThiagoIze ThiagoIze ThiagoIze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgritz @ThiagoIze