Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin: Switch to jmertic's slack notifier action #4079

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Dec 18, 2023

The one we were using is broken. John's is surely the GOAT notifier.

@lgritz lgritz requested a review from jmertic December 18, 2023 05:56
@jmertic
Copy link
Collaborator

jmertic commented Dec 18, 2023

LOL @lgritz - at least with this one you know who to go after when it doesn't work :-).

Copy link

linux-foundation-easycla bot commented Dec 18, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

project_name: "OpenImageIO"
slack_bot_token: ${{ secrets.SLACK_BOT_TOKEN }}
slack_channel: "#release-announcements"
project_logo: "https://artwork.aswf.io/projects/openimageio/icon/color/openimageio-icon-color.png"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this to the icon, as Slack wants square images.

@lgritz
Copy link
Collaborator Author

lgritz commented Dec 18, 2023

I'm just never gonna let you live down forgetting to do the DCO signoff.

@jmertic
Copy link
Collaborator

jmertic commented Dec 19, 2023

@lgritz Not sure why it didn't automatically sign off the commits since I did it through the web browser. Maybe try squashing the commits together?

lgritz and others added 4 commits December 19, 2023 11:30
Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: John Mertic <jmertic@linuxfoundation.org>
Signed-off-by: John Mertic <jmertic@linuxfoundation.org>
Signed-off-by: John Mertic <jmertic@linuxfoundation.org>
Signed-off-by: John Mertic <jmertic@linuxfoundation.org>
@lgritz
Copy link
Collaborator Author

lgritz commented Dec 19, 2023

DCO, done!

Now we just need a CLA from you...

Don't worry, it's "easy".

@jmertic
Copy link
Collaborator

jmertic commented Dec 19, 2023 via email

@lgritz
Copy link
Collaborator Author

lgritz commented Dec 19, 2023

Hahahahahahaha.

@lgritz
Copy link
Collaborator Author

lgritz commented Jan 5, 2024

@jmertic Still waiting for CLA?

@jmertic
Copy link
Collaborator

jmertic commented Jan 8, 2024

Yep...

@jmertic
Copy link
Collaborator

jmertic commented Jan 9, 2024

@lgritz I'm now approved 🥳

@lgritz lgritz merged commit 39200fa into AcademySoftwareFoundation:master Jan 9, 2024
25 checks passed
@lgritz
Copy link
Collaborator Author

lgritz commented Jan 9, 2024

OK, I guess we'll know on Feb 1 if it works!

lgritz added a commit to lgritz/OpenImageIO that referenced this pull request Jan 21, 2024
…dation#4079)

The one we were using is broken. John's is surely the GOAT notifier.

---------

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: John Mertic <jmertic@linuxfoundation.org>
Co-authored-by: John Mertic <jmertic@linuxfoundation.org>
1div0 pushed a commit to 1div0/OpenImageIO that referenced this pull request Feb 24, 2024
…dation#4079)

The one we were using is broken. John's is surely the GOAT notifier.

---------

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: John Mertic <jmertic@linuxfoundation.org>
Co-authored-by: John Mertic <jmertic@linuxfoundation.org>
Signed-off-by: Peter Kovář <peter.kovar@reflexion.tv>
@lgritz lgritz deleted the lg-slack branch March 1, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants