testing: imagebuf_test add benchmarks for iterator traversal #4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help with some other investigation I'm doing, amend imagebuf_test with benchmarks to compare the relative speeds of traversing a big ImageBuf with Iterator, ConstIterator, or just using pointers on an equivalently large array. Signed-off-by: Larry Gritz <lg@larrygritz.com>
|
No objections, right? |
grdanny
approved these changes
Oct 19, 2023
Historical precedent? When dinosaurs roamed the earth, major classes got unit compiled unit tests that live in the same directory as the library containing the class (imagebuf.cpp also has imagebuf_test.cpp, etc.). They are run as part of the testsuite, but they are built along with the library (but they are not "installed", just an artifact of the build that's used for testing). It would have been an equally reasonable choice, I guess, to make that source code itself live in the testsuite and only build when the testsuite is run. But that's not the way I did it at the time. |
|
got it, thanks for explaining. |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 20, 2023
…SoftwareFoundation#4007) To help with some other investigation I'm doing, amend imagebuf_test with benchmarks to compare the relative speeds of traversing a big ImageBuf with Iterator, ConstIterator, or just using pointers on an equivalently large array. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help with some other investigation I'm doing, amend imagebuf_test with benchmarks to compare the relative speeds of traversing a big ImageBuf with Iterator, ConstIterator, or just using pointers on an equivalently large array.