oiiotool: work around static destruction order issue (#3295) #3591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases (at least on Windows, with static linking) the oiiotool main returns zero, but the full process returns 3 error code due to abort() being called. And that is called because a global shared image cache is already destroyed, but the image references from another global (Oiiotool itself) try to use it, get a call into a "pure virtual function" stub that is put by MSVC C runtime into a destroyed object vtable, and that ends up in an abort(). Work around that by making sure various member variables holding ImageRecRef are cleared before main() finishes and global destructors are called.
lgritz
approved these changes
Oct 7, 2022
|
Hmmm, this also makes me think that it probably would have been better for ImageCache::create to have returned a ref-counted pointer. And perhaps for "ot" to be dynamically allocated rather than static, so we can explicitly destroy it before oiiotool exits. |
|
Does this patch fully address #3295 ? |
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 7, 2022
…Foundation#3295) (AcademySoftwareFoundation#3591) In some cases (at least on Windows, with static linking) the oiiotool main returns zero, but the full process returns 3 error code due to abort() being called. And that is called because a global shared image cache is already destroyed, but the image references from another global (Oiiotool itself) try to use it, get a call into a "pure virtual function" stub that is put by MSVC C runtime into a destroyed object vtable, and that ends up in an abort(). Work around that by making sure various member variables holding ImageRecRef are cleared before main() finishes and global destructors are called.
It does for me, but I dunno if it does for the original bug reporter. My guess would be on "yes", from their posted callstack. |
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 8, 2022
…Foundation#3295) (AcademySoftwareFoundation#3591) In some cases (at least on Windows, with static linking) the oiiotool main returns zero, but the full process returns 3 error code due to abort() being called. And that is called because a global shared image cache is already destroyed, but the image references from another global (Oiiotool itself) try to use it, get a call into a "pure virtual function" stub that is put by MSVC C runtime into a destroyed object vtable, and that ends up in an abort(). Work around that by making sure various member variables holding ImageRecRef are cleared before main() finishes and global destructors are called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some cases (at least on Windows, with static linking) the oiiotool main returns zero, but the full process returns 3 error code due to abort() being called. And that is called because a global shared image cache is already destroyed, but the image references from another global (Oiiotool itself) try to use it, get a call into a "pure virtual function" stub that is put by MSVC C runtime into a destroyed object vtable, and that ends up in an abort().
Work around that by making sure various member variables holding ImageRecRef are cleared before main() finishes and global destructors are called.
Tests
N/A -- but it does make running OIIO test suite locally much easier for me. Previously python runners that were launching oiiotool were getting exit code 3 when "everything was fine", so I had to resort to running their final command lines manually. Which is quite cumbersome!
Checklist:
have previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
(adding new test cases if necessary).