[BUG] crash if no default fonts are found #4248
Comments
|
You are quite right! We used to use a regular 'for' and the nullptr signalled the end of valid names, but at some point we switched to range-for and the nullptr should have been removed when we did that. I'm preparing a patch as we speak. |
|
Proposed fix: #4249 |
|
Thanks very much for the full diagnosis, @alanb-sony! It was immediately obvious from your description what needed to be fixed, and I was easily able to go from reading your issue to having a PR submitted in less than 5 minutes. If I'd needed to carefully recreate the conditions of it unable to find any fonts in order to observe the crash and figure out why exactly that was crashing, it might easily have been one of those things I postpone, then falls off the visible part of my inbox, then just sits for months until I notice it again. Wednesday is our scheduled monthly patch release, so this will surly be incorporated into that release. |
The nullptr at the end of default_font_name was left over from a time that we iterated by going through array elements until we hit the nullptr that signalled we had passed the last valid element. At some point we switched to a range-for, which iterates over every element of the array without needing an "end sentinel", and we should have eliminated the nullptr but failed to do so. Fixes #4248 Signed-off-by: Larry Gritz <lg@larrygritz.com>
…tion#4249) The nullptr at the end of default_font_name was left over from a time that we iterated by going through array elements until we hit the nullptr that signalled we had passed the last valid element. At some point we switched to a range-for, which iterates over every element of the array without needing an "end sentinel", and we should have eliminated the nullptr but failed to do so. Fixes AcademySoftwareFoundation#4248 Signed-off-by: Larry Gritz <lg@larrygritz.com>
Actually you sounded quite appreciative, not surly at all. |
…tion#4249) The nullptr at the end of default_font_name was left over from a time that we iterated by going through array elements until we hit the nullptr that signalled we had passed the last valid element. At some point we switched to a range-for, which iterates over every element of the array without needing an "end sentinel", and we should have eliminated the nullptr but failed to do so. Fixes AcademySoftwareFoundation#4248 Signed-off-by: Larry Gritz <lg@larrygritz.com>
Describe the bug
calling
ImageBufAlgo::render_textwithfontset to""crashes if none of the default fonts are found. This is becausedefault_font_nameends with a null pointer.font_file_map.find(fontname)then becomesfont_file_map.find(nullptr)which causesstd::string{nullptr}which crashes.I think the
nullptron the end of the array is superfluous and can simply be removed?The text was updated successfully, but these errors were encountered: