Adsk Contrib - Add DCDM displays and improve HLG OOTF implementation #2051
Conversation
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
| CreateGammaOp(ops, gammaData, TRANSFORM_DIR_FORWARD); | ||
| }; | ||
|
|
||
| registry.addBuiltin("DISPLAY - CIE-XYZ-D65_to_DCDM-D60-BFD", |
There was a problem hiding this comment.
Is this display intended to be used with the ACES2 Builtins (same for the HDR variant)? Note that there is no CAT to D65 performed at the moment in the ACES2 builtins, which I believe was handled similarly in ACES 1.x D60 transforms. Please let me know if I need to update something on the ACES2 PR side.
There was a problem hiding this comment.
Yes, it's intended to be used for the ACES 2 config. But I think what you're proposing is that you would use the "DISPLAY - CIE-XYZ-D65_to_DCDM-D65" for both the D65 and D60 view transforms. The D60 version will essentially have a "D60 sim" type of skew to it. I will remove the D60 versions.
| { | ||
| auto CIE_XYZ_D65_to_ST2084_DCDM_D65_Functor = [](OpRcPtrVec & ops) | ||
| { | ||
| // Scale 1.0 in the reference space to 0.48. The PQ function will interpret |
There was a problem hiding this comment.
Is the scaling related to ACES2 linear_scale_factor? Because it is already applied in the ACES2 builtins. Sorry if I'm getting confused here.
There was a problem hiding this comment.
You are totally right, the scaling actually makes no sense here for several reasons. Removed!
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Add SDR and HDR DCDM built-in displays, which are in the set of Output Transforms recommended by ACES 2.
Improve the Rec.2100 surround algorithm used for the Rec.2100-HLG OOTF and EOTF: