Fix install paths regressions #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rémi Achard <remiachard@gmail.com>
hodoulp
approved these changes
Sep 25, 2021
Signed-off-by: Rémi Achard <remiachard@gmail.com>
remia
changed the title
michdolan
approved these changes
Oct 4, 2021
hodoulp
added a commit
that referenced
this pull request
Oct 4, 2021
* Fix install directory variable for python bindings Signed-off-by: Rémi Achard <remiachard@gmail.com> * Remove hardcoded lib prefix in RPATH handling Signed-off-by: Rémi Achard <remiachard@gmail.com> Co-authored-by: Patrick Hodoul <patrick.hodoul@autodesk.com>
hodoulp
added a commit
that referenced
this pull request
Oct 19, 2021
* Fix install directory variable for python bindings Signed-off-by: Rémi Achard <remiachard@gmail.com> * Remove hardcoded lib prefix in RPATH handling Signed-off-by: Rémi Achard <remiachard@gmail.com> Co-authored-by: Patrick Hodoul <patrick.hodoul@autodesk.com> Co-authored-by: Rémi Achard <remiachard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression introduced in #1471.
In some specific situations, like macOS when using system packages for most of the third party dependencies or when using
DOCIO_INSTALL_EXT_PACKAGES=NONE, there is a possibility of reaching thesrc/bindings/python/CMakeLists.txtwithoutGNUInstallDirsincluded. This patch make sure this module is imported from the root CMakeLists.txt and available for the whole project.The unit test don't expose the issue, because they are installing some of the external package that have the GNUInstallDirs include in theirs Find*.cmake script.
Note that the analysis nightly script already installs the python binding in the root folder, as can be seen in today logs:
Set runtime path of "/python3.9/site-packages/PyOpenColorIO.so" to "$ORIGIN/../..:$ORIGIN/../lib:$ORIGIN"