Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the EXPORT for PyImath. #397

Conversation

lamiller0
Copy link
Contributor

Address Issue #395 where packages that need to link against PyImath can no longer find it.

…to link against PyImath can no

longer find it.
@lgritz
Copy link
Contributor

lgritz commented May 5, 2024

From discussion at the last TSC meeting, we decided that what was really wrong originally that led to the export being removed is that somehow we were installing the module in two places, one of them (incorrectly) in the lib area, instead of strictly in the python site-packages area. THAT is what should be fixed, and if so, then the EXPORT is correct.

Please correct me if my recollection or explanation is wrong, @kdt3rd @meshula @cary-ilm.

We were a little unclear about exactly who should do that fix, and whether we should just go ahead and merge this PR on its own (put the EXPORT back) and separately (but very soon) fix the installation issue, or if we should make a point to do both fixes as one PR.

@meshula
Copy link
Contributor

meshula commented May 6, 2024

@lgritz Yes, you're recalling right. We discussed that we should be pointing into site-packages. We didn't solicit a volunteer though.

@lgritz
Copy link
Contributor

lgritz commented May 10, 2024

Alternate proposal here: #400

@lamiller0 lamiller0 closed this May 10, 2024
@lamiller0 lamiller0 deleted the issue395_export_main branch May 10, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants