Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.1.10 commits and release notes #364

Merged
merged 20 commits into from
Jan 24, 2024

Conversation

cary-ilm
Copy link
Member

Commits for a v3.1.10 patch release. No ABI changes, just build/bug/test fixes.

Build fixes:

  • Fix a problem where downstream projects using Imath would build python bindings even if they weren't requested.

  • Fix for missing std::bit_cast

  • Fix missing/necessary use of IMATH_HOSTDEVICE

  • IMATH_INSTALL_PKG_CONFIG is now on by default, even on Windows

  • Fix calling default constructor by uniform init in TypeTraits

  • Fix redundant PYIMATH_EXPORTS causing compile issues on Windows Clang

  • Update to SO versioning policy:

    This change adopts a policy of appending the MAJOR.MINOR.PATCH software release name to the SONAME to form the real name of the shared library.

    See website/install.rst and
    #339 for more details.

Bug fixes:

  • Fix half to float giving wrong results on older x86_64 CPUs on Windows

Tests:

  • Expand epsilon bounds for m44x pyImath test.

Other:

  • succ()/pred() now use std::nextafter().
  • Rename "docs" to "website".
  • Add missing copyright/license identifiers.

cary-ilm and others added 20 commits January 21, 2024 17:18
openexr.com forwards to openexr.org, but for consistency, let's refer
to all email addresses as @openexr.com, to match the website.

Signed-off-by: Cary Phillips <cary@ilm.com>
…n#333)

Extends epsilon bounds for extracted scale vector comparison to allow up to one representable value of deviation in precision.

Signed-off-by: Zachary Klein <ztklein@lavabit.com>
Now required by readthedocs.com.

Signed-off-by: Cary Phillips <cary@ilm.com>
* Rename "docs" to "website"

"website" is a more accurate term than "docs", so:

- The source lives in the ``website`` subdirectory (was ``docs``)
- The CMake option is now ``BUILD_WEBSITE`` (was ``BUILD_DOCS``)
- The CMake target is now ``website`` (was ``docs``)
- There's no longer a CMake option to install the docs, since copying
  the ``.html`` to the install location is pointless. The ``INSTALL_DOCS``
  option has been removed.

Signed-off-by: Cary Phillips <cary@ilm.com>

* change $ to % in install.rst

Signed-off-by: Cary Phillips <cary@ilm.com>

* rename docs to website in ci_workflows.yml

Signed-off-by: Cary Phillips <cary@ilm.com>

* mention sphinx_press_theme and rst

Signed-off-by: Cary Phillips <cary@ilm.com>

---------

Signed-off-by: Cary Phillips <cary@ilm.com>
…dation#340)

I fixed calling default constructor in ImathTypeTraits.h by using
uniform initialization.

Signed-off-by: Yuya Asano <64895419+sukeya@users.noreply.github.com>
- PortingGuide2-3.md is now PortingGuide.rst
- zlib is probably copypasta from OpenEXR?
- website/Makefile probably added by mistake

Signed-off-by: Cary Phillips <cary@ilm.com>
…ation#350)

See AcademySoftwareFoundation#346: Checking for the language version is not going to help for
incomplete libraries such as on Apple or Android. This fixes this by
using the bit_cast-specific macro.

Signed-off-by: Cary Phillips <cary@ilm.com>
…ftwareFoundation#349)

Similar to
AcademySoftwareFoundation/openexr#1541, there
seems to be no downside to generating the Imath.pc file even on
windows, so for consistency, apply the same default to all platforms.

Signed-off-by: Cary Phillips <cary@ilm.com>
AcademySoftwareFoundation#358)

The lzcnt instruction is not supported on some older x86_64 CPUs. On these
CPUs it will silently execute a bsr instruction instead, leading to wrong
results.

Instead use the bsr instruction and one additional subtraction, which should
have a negligible impact on performance. Additionally, this likely improves
performance on ARM.

Thanks to Ray Molenkamp for tracking down this bug.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Apparently now required by other dependencies

Signed-off-by: Cary Phillips <cary@ilm.com>
…orting targets for dependent projects (AcademySoftwareFoundation#361)

Thanks: Jochen Sprickerhof
Closes: AcademySoftwareFoundation#360

Signed-off-by: Johannes Schauer Marin Rodrigues <josch@mister-muffin.de>
…n#344)

Signed-off-by: Yuya Asano <64895419+sukeya@users.noreply.github.com>
…n#347)

make each file path of ImathConfig.cmake.in and ImathConfigVersion.cmake exact.

Signed-off-by: Yuya Asano <64895419+sukeya@users.noreply.github.com>
Signed-off-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Cary Phillips <cary@ilm.com>
@cary-ilm cary-ilm merged commit 9fe5ed2 into AcademySoftwareFoundation:RB-3.1 Jan 24, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants