Fix building of the project on ARM64 with VisualStudio #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Lemstra <dirk@lemstra.org>
dlemstra
changed the title
lgritz
approved these changes
Jan 8, 2022
|
I think a better solution is to take advantage of the C++20 features when available: https://en.cppreference.com/w/cpp/numeric#Bit_manipulation_.28since_C.2B.2B20.29 apparently, it's already available in newish MSVS versions: https://devblogs.microsoft.com/cppblog/bit-in-visual-studio-2019-version-16-8-preview-2/ So rather than fall all the way back to the "while" loop on other architectures or compilers, they should also check for being on a sufficiently new MSVS (or other C++20 compliant library -- there is a specific testing macro for this) and use the new std functions if available, and those are expected to compile to the most efficient instructions (akin to gcc's |
cary-ilm
pushed a commit
to cary-ilm/Imath
that referenced
this pull request
Jan 17, 2022
…twareFoundation#228) Signed-off-by: Dirk Lemstra <dirk@lemstra.org>
cary-ilm
pushed a commit
that referenced
this pull request
Jan 20, 2022
Signed-off-by: Dirk Lemstra <dirk@lemstra.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds a missing check to fix building with VisualStudio on ARM64. The __lzcnt method is only supported on x86 or x64.